New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pollen.com sensor platform to include asthma info #18024

Merged
merged 3 commits into from Nov 1, 2018

Conversation

Projects
None yet
4 participants
@bachya
Contributor

bachya commented Oct 30, 2018

Description:

This PR bumps pypollencom to 2.2.2, which enables the Pollen.com sensor platform to have asthma-related information. 5 new sensor types are added:

  • Today's Asthma Index (including attributes related to the top 3 asthma-inducing allergens that day)
  • Yesterday's Asthma Index (including attributes related to the top 3 asthma-inducing allergens that day)
  • Tomorrow's Projected Asthma Index
  • 30-day Forecasted Asthma Index Average (including the trend)
  • 30-day Historical Asthma Index Average (including the trend)

This PR also takes the opportunity to do some under-the-hood updates to the architecture; things were getting crowded with so many sensor types.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7281

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: pollen
    zip_code: "12345"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@balloob balloob merged commit 4ee21e6 into home-assistant:dev Nov 1, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 93.013%
Details

@wafflebot wafflebot bot removed the in progress label Nov 1, 2018

@bachya bachya deleted the bachya:pollen-asthma branch Nov 1, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

TYPE_ALLERGY_YESTERDAY: (
'Allergy Index: Yesterday', TYPE_ALLERGY_INDEX, 'mdi:flower', 'index'),
'IndexSensor', 'Allergy Index: Yesterday', 'mdi:flower'),
TYPE_ASTHMA_TODAY: ('IndexSensor', 'Ashma Index: Today', 'mdi:flower'),

This comment has been minimized.

@edif30

edif30 Nov 11, 2018

Contributor

Looks like Asthma is misspelled on lines 65, 67, and 69.

This comment has been minimized.

@edif30

edif30 Nov 11, 2018

Contributor

I just happen to catch this because some entities were not showing up and the docs that were merged did not reflect the yaml configs I had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment