New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add services.yaml entry for new WeMo Humidifier platform service #18032

Merged
merged 3 commits into from Oct 31, 2018

Conversation

Projects
None yet
4 participants
@sqldiablo
Contributor

sqldiablo commented Oct 30, 2018

Description:

Add an entry to services.yaml describing the wemo_set_humidity service offered by the new WeMo Humidifier platform

Related issue (if applicable): addition to #17996

@sqldiablo

This comment has been minimized.

Contributor

sqldiablo commented Oct 30, 2018

I found another typo in fan/wemo.py, so I'm including that fix in this PR as well.

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Oct 30, 2018

Can be merged when build passes.

@sqldiablo

This comment has been minimized.

Contributor

sqldiablo commented Oct 30, 2018

Thanks again for the help, @MartinHjelmare. I created a new fork and am doing branching from the start this time. That should make rebasing actually work this time.

@MartinHjelmare MartinHjelmare merged commit 239e314 into home-assistant:dev Oct 31, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 93.015%
Details

@wafflebot wafflebot bot removed the in progress label Oct 31, 2018

@sqldiablo sqldiablo deleted the sqldiablo:wemo_service_yaml_fix branch Oct 31, 2018

@fabaff fabaff added the Hacktoberfest label Nov 1, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment