New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SMA sensor SSL verification #18033

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Projects
None yet
4 participants
@PhilRW
Contributor

PhilRW commented Oct 30, 2018

Description:

Add the ability to disable SSL verification for SMA sensors.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7287

Example entry for configuration.yaml (if applicable):

sensor sma:
  - platform: sma
    host: 192.168.0.123
    password: !secret sma_password
    ssl: true
    verify_ssl: false
    sensors:
      current_power:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

@PhilRW PhilRW requested a review from kellerza as a code owner Oct 30, 2018

@wafflebot wafflebot bot added the in progress label Oct 30, 2018

@PhilRW PhilRW referenced this pull request Oct 30, 2018

Merged

Update SMA sensor documentation #7287

2 of 2 tasks complete
@kellerza

This comment has been minimized.

Member

kellerza commented Oct 31, 2018

Thx

@kellerza kellerza merged commit 314e5ac into home-assistant:dev Oct 31, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.013%
Details

@wafflebot wafflebot bot removed the in progress label Oct 31, 2018

@kellerza

This comment has been minimized.

Member

kellerza commented Oct 31, 2018

Can you please add this to the docs?

@PhilRW PhilRW deleted the PhilRW:sma-fix branch Oct 31, 2018

@fabaff fabaff added the Hacktoberfest label Nov 1, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment