New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mill, support opeation mode #18059

Merged
merged 1 commit into from Oct 31, 2018

Conversation

Projects
None yet
5 participants
@Danielhiversen
Member

Danielhiversen commented Oct 31, 2018

Description:

Mill, support opeation mode

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@pvizeli pvizeli merged commit 145677e into dev Oct 31, 2018

6 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 93.093%
Details

@wafflebot wafflebot bot removed the in progress label Oct 31, 2018

@pvizeli pvizeli deleted the mill_op_mode branch Oct 31, 2018

else:
_LOGGER.error("Unrecognized operation mode: %s", operation_mode)
return
self.schedule_update_ha_state()

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Oct 31, 2018

Member

Change to async version. We're in async land here.

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Oct 31, 2018

Member

Hold on, we shouldn't schedule a state update at all. This is a polling entity so the service call will schedule a state update.

This comment has been minimized.

@pvizeli

pvizeli Oct 31, 2018

Member

good catch

This comment has been minimized.

@pvizeli

pvizeli Oct 31, 2018

Member

I think that is not needed because it's a polling device?

This comment has been minimized.

@MartinHjelmare

This comment has been minimized.

@Danielhiversen

Danielhiversen Nov 1, 2018

Member

Ahh, sorry.
Will fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment