New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert HAP-python update #18069

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
4 participants
@cdce8p
Member

cdce8p commented Oct 31, 2018

Description:

This PR reverts the HAP-python update made with #17778
Although early testing looked promising, it turned out to cause more errors than it solved.

#17944
#15675 (comment)

Unfortunately this will reopen #17557. However I'll work on a Home Assistant side fix for it soon.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

CC: @wasp100, @timothybrown, @dmonagle, @ehendrix23

@dmonagle

This comment has been minimized.

dmonagle commented Oct 31, 2018

This is unfortunate. Something I didn’t realise myself only this morning is that my successful testing this change was done running in my development environment on macOS. I run my main home assistant server on a raspberry pi. Amateur mistake, I assumed they would behave the same, but I guess especially with HomeKit it’s wise to test against all platforms.

@balloob balloob merged commit 4a3f754 into home-assistant:dev Nov 1, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 93.146%
Details

@wafflebot wafflebot bot removed the in progress label Nov 1, 2018

@cdce8p cdce8p deleted the cdce8p:homekit-revert-update branch Nov 2, 2018

balloob added a commit that referenced this pull request Nov 2, 2018

@balloob balloob referenced this pull request Nov 2, 2018

Merged

0.81.3 #18120

@cdce8p cdce8p referenced this pull request Nov 3, 2018

Merged

Ignore duplicate state changes GarageDoor HomeKit #18149

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment