New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added identifier and name to connect/disconnect events #18078

Merged
merged 2 commits into from Nov 1, 2018

Conversation

Projects
None yet
4 participants
@jaredquinn
Contributor

jaredquinn commented Nov 1, 2018

Description:

Add device identifier and description to keyboard_remote component connect and disconnect events. Previously events were published with no identification details.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7313

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

homeassistant commented Nov 1, 2018

Hi @jaredquinn,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant homeassistant added cla-signed and removed cla-needed labels Nov 1, 2018

@jaredquinn jaredquinn referenced this pull request Nov 1, 2018

Merged

Added example identifier usage matching PR 18078 #7313

2 of 2 tasks complete
@fabaff

fabaff approved these changes Nov 1, 2018

Looks good to me 🐦

@fabaff fabaff merged commit 1c5800d into home-assistant:dev Nov 1, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 93.141%
Details

@wafflebot wafflebot bot removed the in progress label Nov 1, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment