New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xiaomi Smartmi Fresh Air System support #18097

Merged
merged 2 commits into from Nov 5, 2018

Conversation

Projects
None yet
5 participants
@syssi
Member

syssi commented Nov 1, 2018

Description:

Adds Xiaomi Air Fresh VA2 support.

Pull request in home-assistant.io with documentation (if applicable): TBD.

@@ -234,6 +263,12 @@
FEATURE_FLAGS_AIRHUMIDIFIER_CA = (FEATURE_FLAGS_AIRHUMIDIFIER |
FEATURE_SET_DRY)
FEATURE_FLAGS_AIRFRESH = (FEATURE_FLAGS_GENERIC |
# FEATURE_SET_LED |

This comment has been minimized.

@houndci-bot

houndci-bot Nov 1, 2018

continuation line under-indented for visual indent

ATTR_CO2: 'co2',
ATTR_HUMIDITY: 'humidity',
ATTR_MODE: 'mode',
# ATTR_LED: 'led',

This comment has been minimized.

@houndci-bot

houndci-bot Nov 1, 2018

continuation line missing indentation or outdented

@rytilahti

LGTM 👍

@@ -48,7 +49,8 @@
'zhimi.airpurifier.v5',
'zhimi.airpurifier.v6',
'zhimi.humidifier.v1',
'zhimi.humidifier.ca1']),
'zhimi.humidifier.ca1',
'zhimi.airfresh.va2']),

This comment has been minimized.

@rytilahti

rytilahti Nov 5, 2018

Contributor

In the future you may want to like to keep the ]) in a separate line (to avoid two-line diffs when adding models).

@rytilahti rytilahti merged commit d951ed4 into home-assistant:dev Nov 5, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.063%
Details

@wafflebot wafflebot bot removed the in progress label Nov 5, 2018

return
try:
state = await self.hass.async_add_job(

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Nov 6, 2018

Member

Use hass.async_add_executor_job.

This comment has been minimized.

@rytilahti

rytilahti Nov 6, 2018

Contributor

This change would also likely need to be propagated to other xiaomi_miio platforms accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment