New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed pifacecommon 4.1.2 to 4.2.2 to make piface digital i/o boards work on rpi 3 #18101

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
4 participants
@vacumet
Contributor

vacumet commented Nov 1, 2018

Description:

I changed from pifacecommon 4.1.2 to 4.2.2 as it contain a couple of years of bug fixes. Most notably it makes the piface boards work with rpi 3 that have a higher default clock frequency on the SPI bus.

Related issue (if applicable): fixes #

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

[ex-requir]: homeassistant/components/rpi_pfio.py #L12
[ex-import]: homeassistant/components/rpi_pfio.py #L12

Note: My fist pull request :)

@homeassistant

This comment has been minimized.

homeassistant commented Nov 1, 2018

Hi @vacumet,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@wafflebot wafflebot bot added the in progress label Nov 1, 2018

@homeassistant homeassistant added cla-signed and removed cla-needed labels Nov 1, 2018

@vacumet vacumet changed the title from Changed pifacecommon 4.1.2 to 4.2.2 to make piface digital i/o boards work on rpi like 3 to Changed pifacecommon 4.1.2 to 4.2.2 to make piface digital i/o boards work on rpi 3 Nov 1, 2018

@fabaff

fabaff approved these changes Nov 2, 2018

Thanks 🐦

@fabaff fabaff merged commit a39846b into home-assistant:dev Nov 2, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot All contributors have signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.063%
Details

@wafflebot wafflebot bot removed the in progress label Nov 2, 2018

@vacumet vacumet deleted the vacumet:rpi_pfio-version-4.2.2 branch Nov 4, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

@RikVerstijnen RikVerstijnen referenced this pull request Nov 25, 2018

Closed

PiFace does not work #238

@RikVerstijnen

This comment has been minimized.

RikVerstijnen commented Nov 25, 2018

Thanks! This has solved my issue in getting PiFace to work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment