New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deCONZ - manual input fallback in config flow #18116

Merged
merged 6 commits into from Nov 6, 2018

Conversation

Projects
None yet
4 participants
@Kane610
Contributor

Kane610 commented Nov 2, 2018

Add config flow step for manual input
Remove support for loading discovery config from json file

Description:

There is an increase in people who are getting DNS issues resulting in config flow failing. Allow config flow to fall back to manual input of host and port.

Documentation: home-assistant/home-assistant.io#7328

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Nov 2, 2018

@Kane610 Kane610 referenced this pull request Nov 2, 2018

Closed

No deCONZ bridges discovered #33

Kane610 added a commit to home-assistant/home-assistant.io that referenced this pull request Nov 2, 2018

deCONZ is now fully IQS Platinum
When PRs
- home-assistant/home-assistant#18106
- home-assistant/home-assistant#18116
are integrated deCONZ is fully IQS Platinum compliant.

Kane610 added some commits Nov 2, 2018

Add config flow step for manual input
Remove support for loading discovery config from json file
Small cleanup
Fix all translations to step user instead of step init

@Kane610 Kane610 force-pushed the Kane610:deconz-config-flow-manual-input branch from ecfbb13 to 69e30f8 Nov 5, 2018

Small cleanup
Add test_gateway that was forgotten in a previous PR

Kane610 added some commits Nov 5, 2018

@balloob

balloob approved these changes Nov 6, 2018

@balloob balloob merged commit c5d0440 into home-assistant:dev Nov 6, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on deconz-config-flow-manual-input at 93.125%
Details

@wafflebot wafflebot bot removed the in progress label Nov 6, 2018

balloob added a commit to home-assistant/home-assistant.io that referenced this pull request Nov 6, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

deCONZ - manual input fallback in config flow (home-assistant#18116)
* Add config flow step for manual input
Remove support for loading discovery config from json file

* Small cleanup
Fix all translations to step user instead of step init

* Revert to using step_init

* Small cleanup
Add test_gateway that was forgotten in a previous PR

* Fix hound comment

* Fix empty pydocstring

@Kane610 Kane610 deleted the Kane610:deconz-config-flow-manual-input branch Nov 13, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment