New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes initial attribute on the input_number entity #18123

Merged
merged 1 commit into from Nov 2, 2018

Conversation

Projects
None yet
3 participants
@ludeeus
Member

ludeeus commented Nov 2, 2018

Description:

Exposes one additional attribute for initial so we can do templating based on that value like this:
{{ (state_attr('input_number1', 'initial') | float) + 12 }}

Example entry for configuration.yaml (if applicable):

input_number:
  slider1:
    name: Slider
    initial: 30
    min: -20
    max: 35
    step: 1

image

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ludeeus ludeeus requested a review from home-assistant/core as a code owner Nov 2, 2018

@wafflebot wafflebot bot added the in progress label Nov 2, 2018

@fabaff fabaff changed the title from Exposes initial attribute on the input_number entity. to Exposes initial attribute on the input_number entity Nov 2, 2018

@fabaff

fabaff approved these changes Nov 2, 2018

Makes sense to expose the value of initial too. At least the counter is doing it as well. 🐦

@fabaff fabaff merged commit 283407f into home-assistant:dev Nov 2, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0003%) to 93.065%
Details

@wafflebot wafflebot bot removed the in progress label Nov 2, 2018

@ludeeus ludeeus deleted the ludeeus:input-number-attribute branch Nov 2, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment