New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional ttl config to route53 component #18135

Merged
merged 2 commits into from Nov 3, 2018

Conversation

Projects
None yet
4 participants
@pascal-de-ladurantaye
Contributor

pascal-de-ladurantaye commented Nov 3, 2018

Description:

Adds an optional ttl configuration to the new route53 dynamic dns component.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7344

Example entry for configuration.yaml (if applicable):

route53:
  aws_access_key_id: ABC123
  aws_secret_access_key: DEF456
  zone: ZONEID678
  domain: example.com
  records:
    - home
  ttl: 60

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@pascal-de-ladurantaye pascal-de-ladurantaye requested a review from home-assistant/core as a code owner Nov 3, 2018

@homeassistant

This comment has been minimized.

homeassistant commented Nov 3, 2018

Hi @pascal-de-ladurantaye,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Show resolved Hide resolved homeassistant/components/route53.py Outdated
Show resolved Hide resolved homeassistant/components/route53.py Outdated

@bachya bachya merged commit 6a5f9fa into home-assistant:dev Nov 3, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 93.057%
Details

@wafflebot wafflebot bot removed the in progress label Nov 3, 2018

@bachya

This comment has been minimized.

Contributor

bachya commented Nov 3, 2018

Thanks! 😎

@pascal-de-ladurantaye pascal-de-ladurantaye deleted the pascal-de-ladurantaye:optionnal-TTL-route53 branch Nov 3, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment