New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add service to reconnect the bot #18142

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
3 participants
@hobbypunk90
Contributor

hobbypunk90 commented Nov 3, 2018

Description:

Adds a service for reconnecting the hangups bot.

Related issue (if applicable): workaround for #17622

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7347

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@balloob

This comment has been minimized.

Member

balloob commented Nov 3, 2018

Why can't we detect disconnects and reconnect automatically?

@hobbypunk90

This comment has been minimized.

Contributor

hobbypunk90 commented Nov 3, 2018

sadly the hangups lib don't supports it completly, it looks like, there are some scenarios where the lib can detect a disconnect and can automatic reconnect.
But they don't reconnect, or react, if the ip address changes. No exception, no event, nothing happens there...

@balloob

balloob approved these changes Nov 5, 2018

@balloob balloob merged commit 8de79ed into home-assistant:dev Nov 5, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 93.065%
Details

@wafflebot wafflebot bot removed the in progress label Nov 5, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment