New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lovelace: Duplicate ID check on load config + caching #18152

Merged
merged 6 commits into from Nov 6, 2018

Conversation

Projects
None yet
4 participants
@bramkragten
Member

bramkragten commented Nov 3, 2018

Description:

Will now check for duplicate IDs on load_config, to not do this every time you open hass, added caching for load_config.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@bramkragten bramkragten requested a review from home-assistant/core as a code owner Nov 3, 2018

@wafflebot wafflebot bot added the in progress label Nov 3, 2018

@bramkragten bramkragten referenced this pull request Nov 3, 2018

Closed

Add caching to lovelace config #17817

2 of 8 tasks complete
@balloob

balloob approved these changes Nov 5, 2018

@balloob

This comment has been minimized.

Member

balloob commented Nov 5, 2018

ok to merge when lint passes

bramkragten added some commits Nov 5, 2018

@cgarwood cgarwood merged commit 24c110a into home-assistant:dev Nov 6, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 93.052%
Details

@wafflebot wafflebot bot removed the in progress label Nov 6, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Lovelace: Duplicate ID check on load config + caching (home-assistant…
…#18152)

* Add caching + dupl. ID check

* duplicate imports...

* lint

* remove for/else

* found

* Missed one...

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment