New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elk-M1 fixes #18154

Merged
merged 4 commits into from Nov 6, 2018

Conversation

Projects
None yet
4 participants
@gwww
Contributor

gwww commented Nov 3, 2018

Description:

This fixes two problems that were found on the newly released Elk-M1 code in 0.81. Both are setting defaults in voluptuous. Both are minor fixes. No documentation changes required.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

gwww added some commits Oct 27, 2018

@MartinHjelmare

Looks good!

vol.Optional(CONF_TASK): CONFIG_SCHEMA_SUBDOMAIN,
vol.Optional(CONF_THERMOSTAT): CONFIG_SCHEMA_SUBDOMAIN,
vol.Optional(CONF_ZONE): CONFIG_SCHEMA_SUBDOMAIN,
vol.Optional(CONF_AREA, default={CONF_ENABLED: True}):

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Nov 5, 2018

Member

An empty dict would also work as default value, since the default value is passed to the CONFIG_SCHEMA_SUBDOMAIN where the defaults of the dict are populated.

This comment has been minimized.

@gwww

gwww Nov 5, 2018

Contributor

Thank you! I made the change you suggested.

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Nov 5, 2018

Can be merged when build passes.

@cgarwood cgarwood merged commit 7077e19 into home-assistant:dev Nov 6, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 93.063%
Details

@wafflebot wafflebot bot removed the in progress label Nov 6, 2018

@gwww gwww deleted the gwww:elkm1-fix branch Nov 12, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Elk-M1 fixes (home-assistant#18154)
* Fix default value for temperature unit

* Add defaults for subdomains

* Remove unused import

* Fix PR comment

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment