New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Coinbase account wallets #18167

Merged
merged 1 commit into from Nov 12, 2018

Conversation

Projects
None yet
5 participants
@tjorim
Contributor

tjorim commented Nov 3, 2018

Description:

Only add sensor entities for accounts with the specified currencies.
This is a none breaking change. If it's not specified then all account wallets will be loaded.
The default behaviour gives the same results as it does now.

A simple configuration would make all data available for the UI.
Currently there's a discussion (home-assistant/architecture#100)
about removing monitored conditions altogether.

If the user specifies the key without a value (empty list),
then no sensor entities are added for the wallet (e.g. a user only wants exchange rates).

Related issue (if applicable): fixes...
Currently you can just customize the entities to hide them.
However, Coinbase regularly adds new account wallets with new currencies.
You would always need to customize these new entities
and there's no way to get them out of the entity registry itself.

However, this is something I would prefer since I don't need all my 'bank accounts' in HA either
(and there's no point in adding them when the wallet is empty anyway).

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7412

Example entry for configuration.yaml (if applicable):

coinbase:
  api_key: !secret coinbase_api_key
  api_secret: !secret coinbase_api_secret
  account_balance_currencies:
    - EUR
    - BTC

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Filter Coinbase account wallets
Only add sensor entities for accounts with the specified currencies.
This is a none breaking change.
If it's not specified then all account wallets will be loaded.
@balloob

balloob approved these changes Nov 5, 2018

@balloob

This comment has been minimized.

Member

balloob commented Nov 5, 2018

I guess it's fine as 100 is not decided yet. See no docs PR

@balloob balloob added the docs-missing label Nov 5, 2018

@tjorim tjorim referenced this pull request Nov 7, 2018

Merged

Update coinbase.markdown with new docs #7412

2 of 2 tasks complete
@tjorim

This comment has been minimized.

Contributor

tjorim commented Nov 7, 2018

Thanks for the reminder, it's now added.

@frenck frenck removed the docs-missing label Nov 11, 2018

@fabaff fabaff merged commit 9eac11d into home-assistant:dev Nov 12, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.065%
Details

@wafflebot wafflebot bot removed the in progress label Nov 12, 2018

@tjorim tjorim deleted the tjorim:coinbase-accounts branch Nov 12, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Filter Coinbase account wallets (home-assistant#18167)
Only add sensor entities for accounts with the specified currencies.
This is a none breaking change.
If it's not specified then all account wallets will be loaded.

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment