New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP : Add available property #18168

Merged
merged 11 commits into from Nov 5, 2018

Conversation

Projects
None yet
4 participants
@ehendrix23
Contributor

ehendrix23 commented Nov 3, 2018

Description:

Fixes issue where duplicate entities (devices) are created based on discovery when those devices have also been configured as a platform in the configuration.yaml file but with a different name.

Add the available property.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

ehendrix23 added some commits Oct 16, 2018

Enhancements for DirecTV media player
Following enhancements have been made:

1. Added debug logging
2. Added ability to change channel using select_source service of the remote platform.
3. State will now show paused if a recorded program is paused, for live TV playing will always be returned.
4. Added the following attributes:
    a. media_position: current position of the media (in seconds)
    b. media_position_updated_at: timestamp when media_position was updated.
   c. source: current source (channel).
   d. media_isbeingrecorded: if current media is being recorded or not.
   e. media_rating: TV/Movie rating of the media
   f. media_recorded: if current media is recorded or live TV
   g. media_starttime: Timestamp media was aired

Reordered properties to follow same order as how they are in __init__.py of remote platform.
Fixed error and cleaned up few items
Fixed an issue when determining if a program is recorded or not.
Cleaned up some coding.
Fix issue in checking if DTV device is already configured
If a DTV device was configured before, then discovery would add this device again seperately if the name specified in the configuration is different from the name on the DTV.

This issue is fixed now. Part of the fix also ensure to allow multiple "primary" devices on the network to be discovered.
Further also added debug logging to the setup_platform.
Further improvements
Some additional improvements related to handling the DATA_DIRECTV in hass.data.
Fixed flake8 issue
Fixed flake8 issue
Added available property
Added available property
Updated to use get_locations()
Replaced doing the request for getLocations with the get_locations() API from DirectPy instead.
Fix for checking if device is available
Fix for checking if device is available and small update to debug log message.
Fixed lint issue
Fixed lint issue with unused variable by adding ingore for it as this is for a enumerate
Updated try/except and removed available
Updated tr/except having the except by the statement we're doing except on.
Removed available, will be a different PR.
Add available property
Add the available property to the entiry.
@balloob

balloob approved these changes Nov 5, 2018

@balloob balloob merged commit 3d4ff74 into home-assistant:dev Nov 5, 2018

4 of 5 checks passed

WIP work in progress
Details
Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.065%
Details

@wafflebot wafflebot bot removed the in progress label Nov 5, 2018

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Nov 5, 2018

This was WIP and based on another PR that is not merged.

@ehendrix23 ehendrix23 deleted the ehendrix23:Add-available-property branch Nov 5, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment