New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Coinbase icons #18172

Merged
merged 3 commits into from Nov 4, 2018

Conversation

Projects
None yet
3 participants
@tjorim
Contributor

tjorim commented Nov 3, 2018

Description:

This PR adds extra icons (EUR, LTC, USD) and puts them in a dictionary.
Furthermore, it doesn't rely on the name anymore but the actual currency.
We get the icon from the dict with a safe get() and default value as before.

Related issue (if applicable): fixes # NA

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here> NA

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

tjorim added some commits Nov 3, 2018

Add extra icons
and don't rely on the name
Use dictionary for icons
use safe get() with default value
@fabaff

fabaff approved these changes Nov 4, 2018

Looks good to me 🐦

@fabaff fabaff merged commit 42cb23f into home-assistant:dev Nov 4, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 93.062%
Details

@tjorim tjorim deleted the tjorim:coinbase-icons branch Nov 4, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment