New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle TensorFlow like OpenCV #18185

Merged
merged 2 commits into from Nov 4, 2018

Conversation

Projects
None yet
5 participants
@pvizeli
Member

pvizeli commented Nov 4, 2018

Description:

That is the same problem as we have with OpenCV. The python wheels are not available for all platforms (amd64/i386/arm/aarch64) and OS.

With this change, the user needs self-install TensorFlow like OpenCV. Need also an update on Documentation.

@fabaff fabaff added the docs-missing label Nov 4, 2018

@pvizeli pvizeli added this to the 0.82 milestone Nov 4, 2018

@pvizeli

This comment has been minimized.

Member

pvizeli commented Nov 4, 2018

@pvizeli pvizeli removed the docs-missing label Nov 4, 2018

@balloob

balloob approved these changes Nov 4, 2018

@hunterjm

This comment has been minimized.

Contributor

hunterjm commented Nov 4, 2018

You are correct that the wheel is not available on all platforms, but if it is self compiled and pre-installed before this component runs, the component should use it, correct? Why not keep it here for those who do have it available to remove an additional step?

I suppose that removing it also allows a user to choose gpu or cpu if their setup supports it, so not totally against it.

@pvizeli

This comment has been minimized.

Member

pvizeli commented Nov 4, 2018

Because it breaks all build system they have not the wheels. It's the same with dlib and OpenCV. wee need run a solution they bring the best compatibility.

@pvizeli pvizeli merged commit 27e159f into dev Nov 4, 2018

6 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 93.06%
Details

@wafflebot wafflebot bot removed the in progress label Nov 4, 2018

@balloob balloob deleted the fix-tensorflow branch Nov 4, 2018

balloob added a commit that referenced this pull request Nov 5, 2018

Handle TensorFlow like OpenCV (#18185)
* Handle TensorFlow like OpenCV

* Update requirements_all.txt

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment