New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temperature interval Thermostat HomeKit #18192

Merged
merged 1 commit into from Nov 4, 2018

Conversation

Projects
None yet
3 participants
@cdce8p
Member

cdce8p commented Nov 4, 2018

Description:

Although HomeKit and Home Assistant both round to the nearest .0 or .5 value for climate temperatures, under some circumstances it could happen to be other values .1, ...
This PR will make sure that the temperature values are updated correctly.

Related issue (if applicable): fixes #18187

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Reported by: @kamkilt

Fix temperature interval Thermostat HomeKit
* Will round to nearest .0 or .5
@balloob

balloob approved these changes Nov 4, 2018

@balloob balloob merged commit 959fa81 into home-assistant:dev Nov 4, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on homekit-fix-temp-interval at 93.061%
Details

@wafflebot wafflebot bot removed the in progress label Nov 4, 2018

@cdce8p cdce8p deleted the cdce8p:homekit-fix-temp-interval branch Nov 4, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment