New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more type hints to helpers #18196

Merged
merged 5 commits into from Nov 4, 2018

Conversation

Projects
None yet
4 participants
@scop
Contributor

scop commented Nov 4, 2018

Description:

Add more type hints to helpers.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@scop scop requested a review from home-assistant/core as a code owner Nov 4, 2018

@wafflebot wafflebot bot assigned scop Nov 4, 2018

@wafflebot wafflebot bot added the in progress label Nov 4, 2018

from .typing import HomeAssistantType
if TYPE_CHECKING:
import astral # pylint: disable=unused-import

This comment has been minimized.

@houndci-bot

houndci-bot Nov 4, 2018

'astral' imported but unused

@balloob

balloob approved these changes Nov 4, 2018

@balloob balloob merged commit 922f34f into home-assistant:dev Nov 4, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on typing-helpers at 93.06%
Details

@wafflebot wafflebot bot removed the in progress label Nov 4, 2018

kennedyshead pushed a commit to kennedyshead/home-assistant that referenced this pull request Nov 5, 2018

Add more type hints to helpers (home-assistant#18196)
* Test typing for helpers.__init__ and temperature

* Add type hints to helpers.sun

* Add type hints to helpers.signal

* Add type hints to helpers.entity_values

* Add type hints to helpers.dispatcher

@scop scop deleted the scop:typing-helpers branch Nov 5, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment