New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Melissa state_attributes #18201

Merged
merged 4 commits into from Nov 6, 2018

Conversation

Projects
None yet
5 participants
@kennedyshead
Contributor

kennedyshead commented Nov 4, 2018

Description:

They are sensors atm. but I think state_attributes would be far better

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
Show resolved Hide resolved homeassistant/components/climate/melissa.py Outdated

kennedyshead pushed a commit to kennedyshead/home-assistant that referenced this pull request Nov 5, 2018

kennedyshead pushed a commit to kennedyshead/home-assistant that referenced this pull request Nov 5, 2018

@kennedyshead kennedyshead referenced this pull request Nov 5, 2018

Merged

Removes melissa sensors. #18214

2 of 2 tasks complete

balloob added a commit that referenced this pull request Nov 5, 2018

@kennedyshead kennedyshead force-pushed the kennedyshead:melissa_state_attribute branch from 776d14d to aafb9e0 Nov 5, 2018

@kennedyshead kennedyshead force-pushed the kennedyshead:melissa_state_attribute branch from aafb9e0 to bad7ff8 Nov 6, 2018

@balloob balloob merged commit c6f3c23 into home-assistant:dev Nov 6, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 93.058%
Details

@wafflebot wafflebot bot removed the in progress label Nov 6, 2018

@kennedyshead kennedyshead deleted the kennedyshead:melissa_state_attribute branch Nov 6, 2018

@cgarwood

This comment has been minimized.

Member

cgarwood commented Nov 6, 2018

Would this be considered a breaking change?

@kennedyshead

This comment has been minimized.

Contributor

kennedyshead commented Nov 6, 2018

Its the removal of sensors that are breaking imo

@balloob balloob removed the breaking change label Nov 6, 2018

@balloob

This comment has been minimized.

Member

balloob commented Nov 6, 2018

Good point, this is not a breaking change.

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Melissa state_attributes (home-assistant#18201)
* Melissa attributes

* overide device_state_attributes rather than state_attributes

* Selected attributes

* Adding current humidity rather than a state_attribute

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment