New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z-Wave Lock Config Entry Support #18209

Merged
merged 6 commits into from Nov 20, 2018

Conversation

Projects
None yet
5 participants
@cgarwood
Member

cgarwood commented Nov 4, 2018

Description:

Migrates zwave locks to config entry setup.

Related issue (if applicable): N/A
Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

zwave:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
Show resolved Hide resolved tests/components/lock/test_zwave.py Outdated
Show resolved Hide resolved tests/components/lock/test_zwave.py Outdated
Show resolved Hide resolved tests/components/lock/test_zwave.py

@cgarwood cgarwood force-pushed the cgarwood:zw-lock-entry branch from a902387 to 4c1118a Nov 4, 2018

@cgarwood

This comment has been minimized.

Member

cgarwood commented Nov 6, 2018

Waiting on #18180 then I'll rebase

@cgarwood cgarwood force-pushed the cgarwood:zw-lock-entry branch from 4c1118a to d297eb8 Nov 6, 2018

Show resolved Hide resolved homeassistant/components/lock/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/lock/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/lock/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/lock/__init__.py Outdated

cgarwood added some commits Nov 4, 2018

@cgarwood cgarwood changed the title from WIP: Z-Wave Lock Config Entry Support to Z-Wave Lock Config Entry Support Nov 16, 2018

@cgarwood

This comment has been minimized.

Member

cgarwood commented Nov 16, 2018

Anyone have any ideas on the tests? I added some debug statements and it appears that async_setup isn't getting called in components/lock/__init__.py in the test, but it does get called when you actually run HASS. Not sure why, and I've tried different things for the past week to try to fix it and have had 0 luck.

Show resolved Hide resolved tests/components/lock/test_zwave.py Outdated
Show resolved Hide resolved tests/components/lock/test_zwave.py Outdated

@cgarwood cgarwood force-pushed the cgarwood:zw-lock-entry branch from 875f9b4 to 1aecaf1 Nov 16, 2018

@cgarwood

This comment has been minimized.

Member

cgarwood commented Nov 16, 2018

Thanks @MartinHjelmare ! Can't believe it was something so simple, but that's usually how it goes 😃

@balloob balloob merged commit e87ecbd into home-assistant:dev Nov 20, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 93.053%
Details

@wafflebot wafflebot bot removed the Ready for review label Nov 20, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Nov 20, 2018

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant:
  Improve available for Mill heater (home-assistant#18597)
  Z-Wave Lock Config Entry Support (home-assistant#18209)
  Add support for Daikin BRP069B41 (home-assistant#18564)
  Hass.io config check (home-assistant#18576)
  Revert changes that broke UI (home-assistant#18495)
  Add websocket calls to shopping-list (home-assistant#18392)
  Bump Python-Nest to 4.0.5 (home-assistant#18580)
  Adds light switch platform (home-assistant#18562)
  Added unique id to all Wink devices. (home-assistant#18589)

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment