New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add destination and icon #18210

merged 4 commits into from Nov 5, 2018


None yet
4 participants

Dav0815 commented Nov 4, 2018


Added support to filter by destination. Icons are set dynamically to reflect the mode of transport.

Related issue (if applicable): fixes #

Pull request in with documentation (if applicable): home-assistant/

Example entry for configuration.yaml (if applicable):


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@Dav0815 Dav0815 referenced this pull request Nov 4, 2018


Add destination and icon; few more samples #7365

2 of 2 tasks complete

fabaff approved these changes Nov 5, 2018

Looks good to me 🐦

@fabaff fabaff merged commit 6e4ce35 into home-assistant:dev Nov 5, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
coverage/coveralls Coverage decreased (-0.0008%) to 93.064%

@wafflebot wafflebot bot removed the in progress label Nov 5, 2018

@Dav0815 Dav0815 deleted the Dav0815:Transport_NSW branch Nov 5, 2018

@balloob balloob referenced this pull request Nov 29, 2018


0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment