New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud conf #18216

Merged
merged 3 commits into from Nov 5, 2018

Conversation

Projects
None yet
5 participants
@balloob
Member

balloob commented Nov 5, 2018

Description:

  • Store entity filter config on entity filter function
  • Add alexa/google configs to the cloud status command

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Nov 5, 2018

@wafflebot wafflebot bot added the in progress label Nov 5, 2018

@pvizeli

pvizeli approved these changes Nov 5, 2018

@pvizeli pvizeli added this to the 0.82 milestone Nov 5, 2018

@pvizeli pvizeli merged commit bf54582 into dev Nov 5, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 93.099%
Details

@wafflebot wafflebot bot removed the in progress label Nov 5, 2018

@pvizeli pvizeli deleted the cloud-conf branch Nov 5, 2018

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Nov 5, 2018

What does this mean/solve?

@balloob

This comment has been minimized.

Member

balloob commented Nov 5, 2018

balloob added a commit that referenced this pull request Nov 5, 2018

Cloud conf (#18216)
* Add original config to entityfilter

* Add alexa/google config to cloud status call

* Lint

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment