New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruamel-yaml: Check if os has chown #18229

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Projects
None yet
3 participants
@bramkragten
Member

bramkragten commented Nov 5, 2018

Description:

Failed on windows because it doesn't have chown.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@bramkragten bramkragten requested a review from home-assistant/core as a code owner Nov 5, 2018

@wafflebot wafflebot bot added the in progress label Nov 5, 2018

@balloob balloob added this to the 0.82 milestone Nov 5, 2018

@balloob balloob merged commit abf147e into home-assistant:dev Nov 5, 2018

4 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Nov 5, 2018

balloob added a commit that referenced this pull request Nov 5, 2018

@bramkragten bramkragten deleted the bramkragten:ruamel-chown branch Nov 5, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment