New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove turn_on and turn_off feature for clients #18234

Merged
merged 5 commits into from Nov 19, 2018

Conversation

Projects
None yet
3 participants
@ehendrix23
Contributor

ehendrix23 commented Nov 5, 2018

Description:

Remove listing turn_on and turn_off as a supported feature for DVR clients as power_on and power_off do not work and are not supported in the DirecTV API for clients. It is only supported for the main DVR.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
@ehendrix23

This comment has been minimized.

Contributor

ehendrix23 commented Nov 6, 2018

@balloob, FYI not sure what to do here with this check. It failed on:

homeassistant/helpers/device_registry.py:45:4: R1705: Unnecessary "elif" after "return" (no-else-return)

But that is not something I changed. Travis also ran successful on my branch.
Also just checked and PR #16916 brought in the change to device_registry.py with the elif's.

@ehendrix23 ehendrix23 force-pushed the ehendrix23:Disable-TurnOn-and-Off-for-Clients branch from a459aa5 to c06116b Nov 6, 2018

ehendrix23 added some commits Oct 16, 2018

Enhancements for DirecTV media player
Following enhancements have been made:

1. Added debug logging
2. Added ability to change channel using select_source service of the remote platform.
3. State will now show paused if a recorded program is paused, for live TV playing will always be returned.
4. Added the following attributes:
    a. media_position: current position of the media (in seconds)
    b. media_position_updated_at: timestamp when media_position was updated.
   c. source: current source (channel).
   d. media_isbeingrecorded: if current media is being recorded or not.
   e. media_rating: TV/Movie rating of the media
   f. media_recorded: if current media is recorded or live TV
   g. media_starttime: Timestamp media was aired

Reordered properties to follow same order as how they are in __init__.py of remote platform.
Fixed error and cleaned up few items
Fixed an issue when determining if a program is recorded or not.
Cleaned up some coding.
Added available property
Added available property
Disable feature TURN_ON and TURN_OFF for DVR clients
Disable the feature turn_on and turn_off for DVR clients.
self._is_client and raise NotImplementedError
Updated setting self._is_client
Raise NotImplementedError if turn_on or turn_off is called for clients.

@ehendrix23 ehendrix23 force-pushed the ehendrix23:Disable-TurnOn-and-Off-for-Clients branch from c06116b to 4cd8052 Nov 7, 2018

@balloob balloob merged commit cdcc818 into home-assistant:dev Nov 19, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.029%
Details

@wafflebot wafflebot bot removed the in progress label Nov 19, 2018

@ehendrix23 ehendrix23 deleted the ehendrix23:Disable-TurnOn-and-Off-for-Clients branch Nov 19, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Nov 19, 2018

Merge branch 'dev' of https://github.com/home-assistant/home-assistant
…into dev

* 'dev' of https://github.com/home-assistant/home-assistant:
  Bumped ghlocalapi to 0.1.0 (home-assistant#18584)
  Prefix all xiaomi_aqara events (home-assistant#17354)
  Fix MQTT async_added_to_hass (home-assistant#18575)
  Add mikrotik SSL support (home-assistant#17898)
  Reconfigure MQTT binary_sensor component if discovery info is changed (home-assistant#18169)
  Darksky: Expose missing conditions for day 0 forecast (home-assistant#18312)
  Update pyhomematic to 0.1.52 and add features for lights (home-assistant#18499)
  Fix for epson state not updating (home-assistant#18357)
  Support for Point component (home-assistant#17466)
  Template binary sensor to not track all state changes (home-assistant#18573)
  Correct cached stale device tracker handling (home-assistant#18572)
  Add support for sessions (home-assistant#18518)
  Remove turn_on and turn_off feature for clients (home-assistant#18234)
  Log delay and wait_template steps in scripts (home-assistant#18448)
  Logbook speedup (home-assistant#18376)
  Avoid race in entity_platform.async_add_entities() (home-assistant#18445)
  Fix small issue related to topic prefix (home-assistant#18512)
  Enable native support + ADB authentication for Fire TV (home-assistant#17767)
  Re-adding the season attribute (home-assistant#18523)

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment