New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pynetgear to 0.5.1 to fix #17800 #18238

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
5 participants
@Arkkimaagi
Contributor

Arkkimaagi commented Nov 5, 2018

I wanted to make this pull request to get my first hass.io install working with netgear router. It seems that MatMaul has fixed the bug in pynetgear and hopefully it works. I had no idea how to get the fixed version on my home assistant instance on Raspberry Pi Zero, nor how to properly test this from my laptop.

But I was able to run the tests and do these simple changes based on a previous pull request.

Hopefully someone with the know can verify that this actually works and I can get a working version of it on my hass.

https://github.com/MatMaul/pynetgear/releases/tag/0.5.1

Description:

Updates pynetgear to 0.5.1, fixes login infinite loop as seen here: MatMaul/pynetgear@d5bcca5

Related issue (if applicable): fixes #17800

Checklist:

  • The code change is tested and works locally.
    (Sorry, I'm new here, do not know how to properly do this yet.)
  • [X ] Local tests pass with tox. Your PR cannot be merged unless tests pass
    I was able to run the tests tho, seemed to work.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
    Not applicable in any of the above afaik.
@homeassistant

This comment has been minimized.

homeassistant commented Nov 5, 2018

Hi @Arkkimaagi,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@amelchio

Looks good, welcome aboard 😃

@cgarwood cgarwood merged commit 6f568d1 into home-assistant:dev Nov 6, 2018

4 checks passed

Hound No violations found. Woof!
cla-bot All contributors have signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on dev at 93.101%
Details

@wafflebot wafflebot bot removed the in progress label Nov 6, 2018

balloob added a commit that referenced this pull request Nov 7, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment