New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Insteon IOLinc sensor #18250

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
5 participants
@teharris1
Contributor

teharris1 commented Nov 6, 2018

Description:

Fix issue with Insteon IOLinc sensor not reading correctly.

Related issue (if applicable): fixes #18247

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Nov 6, 2018

@teharris1 teharris1 changed the title from Fix IOLinc sensor to Fix Insteon IOLinc sensor Nov 6, 2018

@fabaff

fabaff approved these changes Nov 6, 2018

Thanks 🐦

@fabaff fabaff merged commit ddee5f8 into home-assistant:dev Nov 6, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.05%
Details

@wafflebot wafflebot bot removed the in progress label Nov 6, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

@ethank

This comment has been minimized.

ethank commented Dec 2, 2018

I'm having an issue now with binary sensors showing the wrong status?

@teharris1

This comment has been minimized.

Contributor

teharris1 commented Dec 2, 2018

Can you reproduce the issue? What are you seeing?

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Dec 2, 2018

Please open an issue if you suspect a bug. If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels

Merged PRs should not be used for support or bug reports. Please continue troubleshooting in an issue. Thanks!

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Dec 2, 2018

@teharris1 teharris1 deleted the teharris1:iolinc branch Dec 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.