New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report *which* component didn't return a bool #18258

Merged
merged 2 commits into from Nov 6, 2018

Conversation

Projects
None yet
4 participants
@smurfix
Contributor

smurfix commented Nov 6, 2018

If/when a breaking component returns a non-bool when setting it up, it'd be cool to know which component is the culprit.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

@smurfix smurfix requested a review from home-assistant/core as a code owner Nov 6, 2018

@wafflebot wafflebot bot added the in progress label Nov 6, 2018

@@ -160,8 +160,8 @@ def log_error(msg: str, link: bool = True) -> None:
log_error("Component failed to initialize.")
return False
if result is not True:
log_error("Component did not return boolean if setup was successful. "
"Disabling component.")
log_error("Component {!r} did not return boolean if setup was successful. "

This comment has been minimized.

@houndci-bot

houndci-bot Nov 6, 2018

line too long (83 > 79 characters)

@balloob

balloob approved these changes Nov 6, 2018

@balloob balloob merged commit 4581a74 into home-assistant:dev Nov 6, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 93.136%
Details

@wafflebot wafflebot bot removed the in progress label Nov 6, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Report *which* component didn't return a bool (home-assistant#18258)
* Report *which* component didn't return a bool

* break over-long line

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment