New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR checklist with commented out code check #18272

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
3 participants
@armills
Member

armills commented Nov 6, 2018

Description:

Along with hopefully helping resolve these actual problems, a nudge for people to look at their own code might help catch other quick fixes before anyone else has to review a PR.

Update PR checklist with commented out code check
Along with hopefully helping resolve these actual problems, a nudge for people to look at their own code might help catch other quick fixes before anyone else has to review a PR.
@balloob

balloob approved these changes Nov 6, 2018

@balloob balloob merged commit 917ebed into dev Nov 6, 2018

4 of 6 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
coverage/coveralls First build on pr-template-update at 93.06%
Details

@wafflebot wafflebot bot removed the in progress label Nov 6, 2018

@balloob

This comment has been minimized.

Member

balloob commented Nov 6, 2018

One day I will let my dream come true and build a wizard for submitting a PR that does these things automatically.

@balloob balloob deleted the pr-template-update branch Nov 6, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Update PR checklist with commented out code check (home-assistant#18272)
Along with hopefully helping resolve these actual problems, a nudge for people to look at their own code might help catch other quick fixes before anyone else has to review a PR.

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment