New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon to Darksky summary sensors #18275

Merged
merged 1 commit into from Nov 7, 2018

Conversation

Projects
None yet
4 participants
@leppa
Contributor

leppa commented Nov 6, 2018

Description:

Some cards in HA show entity's icon instead of entity picture (e.g. type: sensor in Lovelace UI). This change sets icon for summary sensors using the same logic as used for their entity picture.

image

Checklist:

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
Show resolved Hide resolved homeassistant/components/sensor/darksky.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/darksky.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/darksky.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/darksky.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/darksky.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/darksky.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/darksky.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/darksky.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/darksky.py Outdated
Show resolved Hide resolved homeassistant/components/sensor/darksky.py Outdated
Darksky: Add icon to summary sensors
The icon changes dynamically, based on summary.

@leppa leppa force-pushed the leppa:darksky-summary-icons branch from 6cc03e4 to 6b7f154 Nov 6, 2018

@fabaff fabaff changed the title from Darksky: Add icon to summary sensors to Add icon to Darksky summary sensors Nov 6, 2018

@fabaff

fabaff approved these changes Nov 7, 2018

Looks good to me 🐦

@fabaff fabaff merged commit 5cee994 into home-assistant:dev Nov 7, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0003%) to 93.062%
Details

@wafflebot wafflebot bot removed the in progress label Nov 7, 2018

@leppa leppa deleted the leppa:darksky-summary-icons branch Nov 7, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Darksky: Add icon to summary sensors (home-assistant#18275)
The icon changes dynamically, based on summary.

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment