Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve version sensor #18292

Merged
merged 4 commits into from Nov 7, 2018
Merged

Improve version sensor #18292

merged 4 commits into from Nov 7, 2018

Commits on Nov 7, 2018

  1. Validate value against valid list

    @tjorim
    tjorim committed Nov 7, 2018
    Copy the full SHA
    28de9b5 View commit details
    Browse the repository at this point in the history

  2. Show correct name 

    Constants in alphabetical order.
Added default name when not showing the local/current version.
    @tjorim
    tjorim committed Nov 7, 2018
    Copy the full SHA
    534e37f View commit details
    Browse the repository at this point in the history

  3. Add icon 

    Icon was already defined but not set
    @tjorim
    tjorim committed Nov 7, 2018
    Copy the full SHA
    1094631 View commit details
    Browse the repository at this point in the history

  4. Unnecessary "elif" after "return" (no-else-return)

    @tjorim
    tjorim committed Nov 7, 2018
    Copy the full SHA
    3b832e7 View commit details
    Browse the repository at this point in the history