New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use async_add_executor_job at the xiaomi_miio platforms #18294

Merged
merged 2 commits into from Nov 7, 2018

Conversation

@syssi
Member

syssi commented Nov 7, 2018

@@ -266,7 +266,7 @@ def supported_features(self):
"""Call a vacuum command handling error messages."""
from miio import DeviceException
try:
await self.hass.async_add_job(partial(func, *args, **kwargs))
await self.hass.async_add_executor_job(partial(func, *args, **kwargs))

This comment has been minimized.

@houndci-bot

houndci-bot Nov 7, 2018

line too long (82 > 79 characters)

@@ -61,7 +61,7 @@ def __init__(self, device):
devices = []
try:
station_info = await self.hass.async_add_job(self.device.status)
station_info = await self.hass.async_add_executor_job(self.device.status)

This comment has been minimized.

@houndci-bot

houndci-bot Nov 7, 2018

line too long (85 > 79 characters)

@MartinHjelmare

Looks good! Can be merged when build passes.

@syssi syssi merged commit df3d82e into home-assistant:dev Nov 7, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.053%
Details

@wafflebot wafflebot bot removed the in progress label Nov 7, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment