New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyruter to 1.1.0 to be able to reuse aiohttp session. #18310

Merged
merged 2 commits into from Nov 7, 2018

Conversation

Projects
None yet
4 participants
@ludeeus
Member

ludeeus commented Nov 7, 2018

Description:

This updates pyruter to be able to reuse the aiohttp session as discussed in the comments here #18237 (comment)
Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

sensor:
  platform: ruter
  stop_id: 2190400

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@MartinHjelmare

Looks good!

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Nov 7, 2018

Can be merged when build passes.

@cgarwood cgarwood merged commit 0bf054f into home-assistant:dev Nov 7, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.029%
Details

@wafflebot wafflebot bot removed the in progress label Nov 7, 2018

@ludeeus ludeeus deleted the ludeeus:sensor.ruter_reuse_session branch Nov 7, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Update pyruter to 1.1.0 to be able to reuse aiohttp session. (home-as…
…sistant#18310)

* Update pyruter to 1.1.0 to be able to reuse aiohttp session.

* Taged correct version of pyruter.

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment