New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional precision configuration option to generic_thermostat. #18317

Merged
merged 4 commits into from Nov 8, 2018

Conversation

Projects
None yet
4 participants
@partofthething
Contributor

partofthething commented Nov 8, 2018

Description:

The generic_thermostat precision is hard-coded to 1 degree in Fahrenheit mode which is a bit too coarse for some tastes. This PR adds an optional precision config option allowing finer control over the component.

Related issue (if applicable): No open issue but this was discussed a bit in the forum.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7434

Example entry for configuration.yaml (if applicable):

climate:
    - platform: generic_thermostat
      name: Upstairs
      heater: input_boolean.upstairs_heat
      target_sensor: sensor.zooz3_temperature
      precision: 0.1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@fabaff

fabaff approved these changes Nov 8, 2018

Looks good to me 🐦

@fabaff fabaff merged commit 5995423 into home-assistant:dev Nov 8, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 93.03%
Details

@wafflebot wafflebot bot removed the in progress label Nov 8, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Added optional precision configuration option to generic_thermostat. (h…
…ome-assistant#18317)

* Added optional precision configuration option to generic_thermostat.

* Added optional precision configuration option to generic_thermostat.

* Style update.

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment