New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyhaversion to 2.0.2 #18318

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
4 participants
@ludeeus
Member

ludeeus commented Nov 8, 2018

Description:

Fixes an issue with the new features added in sensor.version reported in the #beta channel on Discord.
https://discordapp.com/channels/330944238910963714/427516175237382144/509922015759564800

Where this configuration:

sensor:
  - platform: version
    image: qemux86-64
    source: hassio

Resulted in this message:

Error fetching version information for hassio, 'qemux86-64'

As a result of that, the sensor did not show version attributes for supervisor, cli or hassos, only homeassistant.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@fabaff

fabaff approved these changes Nov 8, 2018 edited

Thanks 🐦

@fabaff fabaff merged commit 7fed49c into home-assistant:dev Nov 8, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 93.029%
Details

@wafflebot wafflebot bot removed the in progress label Nov 8, 2018

@ludeeus ludeeus deleted the ludeeus:pyhaversion_bump branch Nov 8, 2018

@balloob balloob added this to the 0.82 milestone Nov 8, 2018

balloob added a commit that referenced this pull request Nov 8, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment