New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Velbus climate platform #18319

Merged
merged 1 commit into from Nov 8, 2018

Conversation

@balloob
Member

balloob commented Nov 8, 2018

Description:

We accidentally merged a platform in #18100 that used non-official operation modes. This is not something that is allowed and so removing this platform.

The platform can be submitted again with the correct operation modes.

Using incorrect operation modes will break Alexa, Google Assistant, HomeKit and our UI. All for which we will get issues opened and people blame us. We have guidelines for a reason, they have to be followed.

Related issue (if applicable): #18100

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7435

@balloob balloob merged commit 54b0cde into dev Nov 8, 2018

6 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on remove-velbus-climate at 93.039%
Details

@wafflebot wafflebot bot removed the in progress label Nov 8, 2018

@balloob balloob deleted the remove-velbus-climate branch Nov 8, 2018

balloob added a commit that referenced this pull request Nov 9, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment