New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

huawei_router: fix last device being ignored #18329

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
4 participants
@abmantis
Contributor

abmantis commented Nov 8, 2018

Description:

The regex was not matching the last device on the list, so it was never added to HA.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@amelchio amelchio merged commit b803075 into home-assistant:dev Nov 9, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.037%
Details

@wafflebot wafflebot bot removed the in progress label Nov 9, 2018

@amelchio

This comment has been minimized.

Member

amelchio commented Nov 9, 2018

I guess that's why we prefer this kind of stuff in external libraries 😉

balloob added a commit that referenced this pull request Nov 9, 2018

@balloob balloob referenced this pull request Nov 9, 2018

Merged

0.82 #18335

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment