New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Lutron RadioRA2 support, adding switches and scenes #18330

Merged
merged 5 commits into from Dec 25, 2018

Conversation

@cdheiser
Copy link
Contributor

cdheiser commented Nov 9, 2018

Description:

  • Update the version of pylutron to 0.2 which has various bug fixes.
  • Switch to pylutron's per-device subscribe
  • Add switch support, and configure any non-dimmable output as a switch.
  • Add scene support, using any configured keypad button with a corresponding LED as a scene.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7444

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Improve Lutron RadioRA2 support, adding switch and scene support.
- Update the version of pylutron to 0.2 which has various bug fixes.
- Switch to pylutron's per-device subscribe
- Add switch support, and configure any non-dimmable output as a switch.
- Add scene support, using any configured keypad button with a corresponding LED as a scene.
@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Nov 9, 2018

Hi @cdheiser,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Show resolved Hide resolved homeassistant/components/switch/lutron.py Outdated
Show resolved Hide resolved homeassistant/components/lutron.py
Show resolved Hide resolved homeassistant/components/scene/lutron.py Outdated
Show resolved Hide resolved homeassistant/components/scene/lutron.py Outdated
Show resolved Hide resolved homeassistant/components/scene/lutron.py Outdated
Show resolved Hide resolved homeassistant/components/switch/lutron.py Outdated
def device_state_attributes(self):
"""Return the state attributes."""
attr = {}
attr['Lutron Integration ID'] = self._lutron_device.id

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Nov 21, 2018

Member

Keys in state attributes should be lowercase snakecase.

This comment has been minimized.

@cdheiser

cdheiser Nov 22, 2018

Contributor

This was done to remain consistent with the existing light/lutron.py. I've updated the new switch code. I could update and include a fix for the light in this pull request as well.

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Nov 22, 2018

Member

Could you make a separate PR with that correction for the light platform? It will be a breaking change. Thanks!

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good! @pvizeli?

@cdheiser

This comment has been minimized.

Copy link
Contributor

cdheiser commented Dec 6, 2018

@pvizeli any other comments/requests?

@cdheiser

This comment has been minimized.

Copy link
Contributor

cdheiser commented Dec 24, 2018

bump?

@MartinHjelmare MartinHjelmare changed the title Improve Lutron RadioRA2 support, adding switch and scene support. Improve Lutron RadioRA2 support, adding switches and scenes Dec 25, 2018

@MartinHjelmare MartinHjelmare merged commit b2081c5 into home-assistant:dev Dec 25, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 93.027%
Details

@wafflebot wafflebot bot removed the in progress label Dec 25, 2018

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Improve Lutron RadioRA2 support, adding switches and scenes (home-ass…
…istant#18330)

* Improve Lutron RadioRA2 support, adding switch and scene support.

- Update the version of pylutron to 0.2 which has various bug fixes.
- Switch to pylutron's per-device subscribe
- Add switch support, and configure any non-dimmable output as a switch.
- Add scene support, using any configured keypad button with a corresponding LED as a scene.

* Fixes for comments in pull request home-assistant#18330

* More fixes for comments in pull request home-assistant#18330

* Remove unused imports

* Cleanup in docstrings for Lutron scene support.

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 25, 2018

Merge branch 'dev' into current
* dev: (27 commits)
  Add device_id configuration option to Bluetooth tracker (home-assistant#18539)
  Add homematicip cloud full flush measuring switch (home-assistant#19247)
  Added support for triggered state on NX584 alarm. (home-assistant#19524)
  Add HomematicIP SMI55 device (home-assistant#19400)
  Clean up homematicip cloud (home-assistant#19481)
  Improve Lutron RadioRA2 support, adding switches and scenes (home-assistant#18330)
  Remove global from ZHA application controller (home-assistant#19557)
  Update homekit controller to homekit==0.12.0 (home-assistant#19549)
  Improve handling of MQTT light discovery (home-assistant#19436)
  Fix support for base topic for empty values in MQTT discovery msg (home-assistant#19501)
  Configure ZHA entity on new ZHA device join (home-assistant#19470)
  Add hub- and device-info for tellduslive (home-assistant#19180)
  Fix issues in ZHA light (home-assistant#19368)
  Updated to support per device find iphone sound. (home-assistant#19535)
  Change ISY binary_sensor subnode to hex (home-assistant#19471)
  increase robustness, when something upstream fails (home-assistant#19493)
  Support ZHA light turn_off transition (home-assistant#19531)
  Pywemo version bump (home-assistant#19538)
  Make ZHA entities non-polled by default (home-assistant#19536)
  Add ZHA occupancy sensor (home-assistant#19365)
  ...

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment