New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mythic Beasts DNSAPI Component #18333

Merged
merged 5 commits into from Dec 20, 2018

Conversation

Projects
None yet
6 participants
@thinkl33t
Copy link
Contributor

thinkl33t commented Nov 9, 2018

Description:

This adds a dns component to automatically update your domain at mythic beasts on IP changes.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7446

Example entry for configuration.yaml (if applicable):

mythicbeastsdns:
  host: hostname
  domain: your.domain
  password: APIKEYFORMYTHICBEASTS

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Show resolved Hide resolved homeassistant/components/mythicbeastsdns.py Outdated
Show resolved Hide resolved homeassistant/components/mythicbeastsdns.py Outdated
Show resolved Hide resolved homeassistant/components/mythicbeastsdns.py Outdated

@thinkl33t thinkl33t force-pushed the thinkl33t:mythic-beasts-dns branch from 30908e1 to f5ac1c5 Nov 24, 2018

@thinkl33t

This comment has been minimized.

Copy link
Contributor

thinkl33t commented Nov 25, 2018

I've made the above changes, any chance of a re-review please @fabaff

@thinkl33t thinkl33t force-pushed the thinkl33t:mythic-beasts-dns branch from 536c7ad to 65ef88d Nov 26, 2018

@ludeeus

This comment has been minimized.

Copy link
Member

ludeeus commented Nov 27, 2018

@thinkl33t

This comment has been minimized.

Copy link
Contributor

thinkl33t commented Nov 29, 2018

I've done the above, but the tests are still mocking the API.

Should I:

  • Leave the tests as they are
  • Replace them with mock calls to the library that just 'return true' and 'return false'
  • Delete the tests entirely
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

We usually mock out the library calls.

Show resolved Hide resolved homeassistant/components/mythicbeastsdns.py Outdated
Show resolved Hide resolved tests/components/test_mythicbeastsdns.py Outdated
Show resolved Hide resolved tests/components/test_mythicbeastsdns.py Outdated
Show resolved Hide resolved tests/components/test_mythicbeastsdns.py Outdated
Show resolved Hide resolved tests/components/test_mythicbeastsdns.py Outdated
Show resolved Hide resolved tests/components/test_mythicbeastsdns.py Outdated
Show resolved Hide resolved tests/components/test_mythicbeastsdns.py Outdated
Show resolved Hide resolved tests/components/test_mythicbeastsdns.py Outdated
Show resolved Hide resolved tests/components/test_mythicbeastsdns.py Outdated

@thinkl33t thinkl33t force-pushed the thinkl33t:mythic-beasts-dns branch 2 times, most recently from 325fc6c to 6937ab4 Dec 7, 2018

Show resolved Hide resolved tests/components/test_mythicbeastsdns.py Outdated
Show resolved Hide resolved tests/components/test_mythicbeastsdns.py Outdated
Show resolved Hide resolved tests/components/test_mythicbeastsdns.py Outdated

@thinkl33t thinkl33t force-pushed the thinkl33t:mythic-beasts-dns branch 2 times, most recently from a7379da to 2bc51e2 Dec 8, 2018

@thinkl33t

This comment has been minimized.

Copy link
Contributor

thinkl33t commented Dec 10, 2018

I believe this is now good to go 😁

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good! One comment.

Show resolved Hide resolved .coveragerc Outdated

@thinkl33t thinkl33t force-pushed the thinkl33t:mythic-beasts-dns branch from 2bc51e2 to 7ed4fb1 Dec 20, 2018

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Great!

@MartinHjelmare MartinHjelmare merged commit d42d854 into home-assistant:dev Dec 20, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 93.052%
Details

@wafflebot wafflebot bot removed the in progress label Dec 20, 2018

mxworm added a commit to mxworm/home-assistant that referenced this pull request Dec 21, 2018

Merge branch 'dev' into current
* dev: (75 commits)
  Add native ESPHome Home Assistant state feature (home-assistant#19429)
  Add new sensor platform to expose Islamic prayer times (home-assistant#19444)
  Add timeout to RainMachine login (home-assistant#19476)
  Reorder FLOW entries in config_entries.py (home-assistant#19475)
  Update pynetgear to 0.5.2 (home-assistant#19490)
  Rename ocr.png to ssocr-(entity_name).png to allow multiple instances (home-assistant#18634)
  Add Mythic Beasts DNSAPI Component (home-assistant#18333)
  Adds battery_percent which had been introduced with pyatmo 1.4 and resolves unknown var warning. (home-assistant#19309)
  Bump Pybotvac To Support D7 On Latest Firmware (home-assistant#19463)
  Add device registry to MQTT alarm control panel (home-assistant#19331)
  Add device registry to MQTT lock (home-assistant#19333)
  Bump pyharmony (home-assistant#19460)
  Add testcase test_entity_id_update
  Add device registry to MQTT climate
  Updated frontend to 20181219.0
  Update translations
  ZHA entity ZCL reporting configuration (home-assistant#19177)
  Use web sockets for Harmony HUB (home-assistant#19440)
  Correct calls to subscription.async_unsubscribe_topics (home-assistant#19414)
  Various updates (home-assistant#19449)
  ...

dshokouhi added a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018

Add Mythic Beasts DNSAPI Component (home-assistant#18333)
* Add Mythic Beasts DNSAPI Component

* Added timeout, and tests for exceptions while updating

* Move API to external module

* Move mbddns import into function

* Updated tests to mock out mbddns library

@balloob balloob referenced this pull request Jan 10, 2019

Merged

0.85.0 #19897

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment