New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sensor.launch to sensor.launch_library #18337

Merged
merged 1 commit into from Nov 9, 2018

Conversation

Projects
None yet
5 participants
@ludeeus
Member

ludeeus commented Nov 9, 2018

Description:

As discussed in #18274 this renames this (unreleased) sensor plaform sensor.launch to sensor.launch_library

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7447

Example entry for configuration.yaml (if applicable):

sensor:
  platform: launch_library

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@amelchio amelchio merged commit d34c47a into home-assistant:dev Nov 9, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 93.046%
Details

@wafflebot wafflebot bot removed the in progress label Nov 9, 2018

@ludeeus ludeeus deleted the ludeeus:rename-sensor.launch branch Nov 9, 2018

@balloob balloob removed this from the 0.82 milestone Nov 10, 2018

@apeeters

This comment has been minimized.

apeeters commented Nov 10, 2018

I bit late maybe, but why not call it space_launch? launch_library is as generic as launch :)

@ludeeus

This comment has been minimized.

Member

ludeeus commented Nov 10, 2018

It's the name of the service it uses @apeeters

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment