New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wunderlist component #18339

Merged
merged 4 commits into from Nov 27, 2018

Conversation

Projects
None yet
6 participants
@lasote
Copy link
Contributor

lasote commented Nov 9, 2018

Description:

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#7448

Example entry for configuration.yaml (if applicable):

wunderlist:
  client_id: YOUR_CLIENT_ID
  access_token: YOUR_ACCESS_TOKEN

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Nov 9, 2018

@lasote lasote referenced this pull request Nov 9, 2018

Merged

Wunderlist Docs #7448

2 of 2 tasks complete

lasote and others added some commits Nov 12, 2018

@balloob balloob merged commit 7b3b7d2 into home-assistant:dev Nov 27, 2018

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA

@wafflebot wafflebot bot removed the in progress label Nov 27, 2018

_LOGGER.error("Invalid credentials")
return False

hass.services.register(DOMAIN, 'create_task', data.create_task)

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Nov 27, 2018

Member

The service schema should be used here.

starred = call.data.get(CONF_STARRED)
list_id = self._list_by_name(list_name)
self._client.create_task(list_id, task_title, starred=starred)
return True

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Nov 27, 2018

Member

Nothing is checking this return value. Please remove the statement.

SERVICE_CREATE_TASK = 'create_task'

SERVICE_SCHEMA_CREATE_TASK = vol.Schema({
vol.Required(CONF_LIST_NAME): cv.string,

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Nov 27, 2018

Member

We use constants named ATTR_* in service schemas.

@lasote

This comment has been minimized.

Copy link
Contributor

lasote commented Nov 28, 2018

@MartinHjelmare do I need to perform the changes now it has been merged?

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Nov 28, 2018

Yes, please open a new PR.

@philhawthorne

This comment has been minimized.

Copy link
Contributor

philhawthorne commented Dec 8, 2018

Think this PR is missing the new-platform tag

@balloob balloob referenced this pull request Dec 12, 2018

Merged

0.84 #19215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment