New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more type hints to helpers #18350

Merged
merged 2 commits into from Nov 11, 2018

Conversation

Projects
None yet
3 participants
@scop
Contributor

scop commented Nov 10, 2018

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

scop added some commits Nov 7, 2018

@scop scop requested a review from home-assistant/core as a code owner Nov 10, 2018

@wafflebot wafflebot bot assigned scop Nov 10, 2018

@wafflebot wafflebot bot added the in progress label Nov 10, 2018

@balloob balloob merged commit 9411fca into home-assistant:dev Nov 11, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0003%) to 93.046%
Details

@wafflebot wafflebot bot removed the in progress label Nov 11, 2018

@scop scop deleted the scop:typing-helpers branch Nov 11, 2018

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Nov 12, 2018

Add more type hints to helpers (home-assistant#18350)
* Add type hints to helpers.entityfilter

* Add type hints to helpers.deprecation

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Nov 12, 2018

Add more type hints to helpers (home-assistant#18350)
* Add type hints to helpers.entityfilter

* Add type hints to helpers.deprecation

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Add more type hints to helpers (home-assistant#18350)
* Add type hints to helpers.entityfilter

* Add type hints to helpers.deprecation

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment