New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HAP-python to 2.4.0 #18355

Merged
merged 1 commit into from Nov 10, 2018

Conversation

Projects
None yet
4 participants
@cdce8p
Member

cdce8p commented Nov 10, 2018

Description:

Changes

  • Fixed issue that caused revert of #17778
  • AccessoryDriver.safe_mode option to enable pairing through zeroconf errors (PR adding this function will follow soon)
  • Fixed CLOSE_WAIT issue and open sockets
  • Fixed slow shutdown with python3.7

Full changelog: https://github.com/ikalchev/HAP-python/blob/dev/CHANGELOG.md

Related issues:
#15675
#16692
#17365
https://community.home-assistant.io/t/homekit-devices-not-responding/74656

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@dmonagle, @ehendrix23 can you both do some testing with this PR. Especially for your respective issues (CLOSE_WAIT and long time to stop HAP)? I don't want to revert it again if it worsens the connection with HomeKit.

@fabaff

fabaff approved these changes Nov 10, 2018

Thanks 🐦

@fabaff fabaff merged commit 132bb79 into home-assistant:dev Nov 10, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.0005%) to 93.045%
Details

@wafflebot wafflebot bot removed the in progress label Nov 10, 2018

@cdce8p cdce8p deleted the cdce8p:homekit-update-2.4.0 branch Nov 10, 2018

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Nov 12, 2018

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Nov 12, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

@dmonagle

This comment has been minimized.

dmonagle commented Nov 19, 2018

@cdce8p I've just had a day off so I've spent a bit of time with this. After replicating my setup on hassbian and manually upgrading HAP-python to 2.4.1, I still have issues running on 82.1. Out of pure interest, I installed the dev branch with the same result.

What I am seeing is that when HomeKit first starts, I have a window of maybe a minute where I can operate switches in the Home interface and see them replicated in the Home Assistant GUI. After this time they get a red "No Response" in Home.

Interestingly, even while the switches all show as No Response, I still seem to get notifications (ie. Garage door was opened)

Please let me know if there is anything you'd like me to run/diagnose on this setup. It's Hassbian running on a Raspberry Pi 3 Model B Rev 1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment