New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error handling in Tibber #18363

Merged
merged 2 commits into from Nov 11, 2018

Conversation

Projects
None yet
3 participants
@Danielhiversen
Member

Danielhiversen commented Nov 10, 2018

Description:

Better error handling in Tibber

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@Kane610

Looks good!

@Danielhiversen Danielhiversen merged commit f0a0ce5 into dev Nov 11, 2018

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.009%) to 93.045%
Details

@wafflebot wafflebot bot removed the in progress label Nov 11, 2018

@Danielhiversen Danielhiversen deleted the tibber_error_handle branch Nov 11, 2018

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Nov 12, 2018

Better error handling in Tibber (home-assistant#18363)
* Better error handling in Tibber

* return if received error

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Nov 12, 2018

Better error handling in Tibber (home-assistant#18363)
* Better error handling in Tibber

* return if received error

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Better error handling in Tibber (home-assistant#18363)
* Better error handling in Tibber

* return if received error

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment