New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return color information in Alexa Smart Home response #18368

Merged
merged 1 commit into from Nov 11, 2018

Conversation

Projects
None yet
4 participants
@jackwilsdon
Contributor

jackwilsdon commented Nov 11, 2018

Description: Return color information in Alexa Smart Home response

This PR adds the color attribute for the Alexa.ColorController interface in the response, fixing an error that occurs within Alexa when setting the color of a device.

Related issue (if applicable): fixes #18367

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@jackwilsdon jackwilsdon force-pushed the jackwilsdon:color_controller_properties branch from 43471f8 to d1efb40 Nov 11, 2018

@jackwilsdon jackwilsdon force-pushed the jackwilsdon:color_controller_properties branch from d1efb40 to ef79f16 Nov 11, 2018

@balloob

Nice!

@balloob balloob merged commit 5b9a9d8 into home-assistant:dev Nov 11, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 93.034%
Details

@wafflebot wafflebot bot removed the in progress label Nov 11, 2018

@jackwilsdon jackwilsdon deleted the jackwilsdon:color_controller_properties branch Nov 11, 2018

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Nov 12, 2018

sqldiablo added a commit to sqldiablo/home-assistant that referenced this pull request Nov 12, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment