New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hangouts notify #18372

Merged
merged 2 commits into from Nov 11, 2018

Conversation

Projects
None yet
4 participants
@MartinHjelmare
Member

MartinHjelmare commented Nov 11, 2018

Description:

  • Only pass the data key value to the hangouts send message service if we receive data from the notify service base call.
  • Remove the notify service schema from the hangouts notify platform, as it isn't used. Platforms can't overwrite base component schemas.

Related issue (if applicable):
fixes #18360

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

MartinHjelmare added some commits Nov 11, 2018

Remove notify schema from hangouts platform
* Notify platforms shouldn't overwrite the notify component service
  schema. That has no effect.
@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Nov 11, 2018

I can't test this live. If someone that is affected by the bug can test this branch, that would be awesome!

@edif30

This comment has been minimized.

Contributor

edif30 commented Nov 11, 2018

Just tested. Seems to be working with this fix!

@balloob balloob merged commit 02cc6a2 into home-assistant:dev Nov 11, 2018

5 checks passed

Hound No violations found. Woof!
WIP Legacy commit status override — see details
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.002%) to 93.045%
Details

@wafflebot wafflebot bot removed the in progress label Nov 11, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Fix hangouts notify (home-assistant#18372)
* Remove notify schema from hangouts platform

* Notify platforms shouldn't overwrite the notify component service
  schema. That has no effect.

* Fix hangouts service data key value

balloob added a commit that referenced this pull request Nov 15, 2018

Fix hangouts notify (#18372)
* Remove notify schema from hangouts platform

* Notify platforms shouldn't overwrite the notify component service
  schema. That has no effect.

* Fix hangouts service data key value

@balloob balloob referenced this pull request Nov 15, 2018

Merged

0.82.1 #18481

@MartinHjelmare MartinHjelmare deleted the MartinHjelmare:fix-hangouts-notify branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment