New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for keypad keypress #18393

Merged
merged 2 commits into from Nov 12, 2018

Conversation

Projects
None yet
5 participants
@gwww
Contributor

gwww commented Nov 12, 2018

Description:

Adds support for reporting keypad keypresses on the keypad sensor. A new single device_state_attribute is added. No doc changes or config changes required.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@BioSehnsucht

This comment has been minimized.

Contributor

BioSehnsucht commented Nov 12, 2018

Not sure if Travis-CI failed because there was an actual problem with requirements_all, or if it just failed because sometimes it does that ...

@MartinHjelmare

This comment has been minimized.

Member

MartinHjelmare commented Nov 12, 2018

Please read and check the appropriate boxes in the checklist in the PR template.

Run script/gen_requirements.py and commit the changes.

@BioSehnsucht

This comment has been minimized.

Contributor

BioSehnsucht commented Nov 12, 2018

Ah, looks like the requirements does need updating, I was just casually looking at the issue and saw that Travis had failed, didn't actually look at the code.

@fabaff

fabaff approved these changes Nov 12, 2018

Thanks 🐦

@fabaff fabaff merged commit 275b485 into home-assistant:dev Nov 12, 2018

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.047%
Details

@wafflebot wafflebot bot removed the in progress label Nov 12, 2018

@gwww

This comment has been minimized.

Contributor

gwww commented Nov 12, 2018

Thank you!

@gwww gwww deleted the gwww:elkm1-frs branch Nov 12, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Add support for keypad keypress (home-assistant#18393)
* Add support for keypad keypress

* Update requirements_all

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment