New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update waze_travel_time.py attribution #18399

Merged
merged 1 commit into from Nov 12, 2018

Conversation

Projects
None yet
3 participants
@hmmbob
Contributor

hmmbob commented Nov 12, 2018

Description:

Updated Waze travel time sensor attribution to the one Waze suggests (“Powered by Waze”, see:
https://developers.google.com/waze/intro-transport#attribution-guidelines-and-authorized-modifications) as the current string makes less sense.

Related issue (if applicable): n/a

Pull request in home-assistant.io with documentation (if applicable): n/a

Example entry for configuration.yaml (if applicable):

N/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@fabaff

fabaff approved these changes Nov 12, 2018

🐦

@fabaff fabaff merged commit 1f06d6a into home-assistant:dev Nov 12, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.009%) to 93.038%
Details

@wafflebot wafflebot bot removed the in progress label Nov 12, 2018

@hmmbob hmmbob deleted the hmmbob:patch-1 branch Nov 12, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment