New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sense will not list removed devices #18410

Merged
merged 2 commits into from Nov 13, 2018

Conversation

Projects
None yet
3 participants
@kbickar
Contributor

kbickar commented Nov 12, 2018

Description:

Sense was previously adding all devices as binary sensors, including those that the user had removed. This fix changes it to only include those that are listable in the app

kbickar added some commits Nov 12, 2018

@fabaff

fabaff approved these changes Nov 13, 2018

Looks good to me 🐦

@fabaff fabaff merged commit f78dcb9 into home-assistant:dev Nov 13, 2018

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 93.047%
Details

@wafflebot wafflebot bot removed the in progress label Nov 13, 2018

zxdavb added a commit to zxdavb/home-assistant that referenced this pull request Nov 13, 2018

Sense will not list removed devices (home-assistant#18410)
* Sense will not list removed devices

* quote update

@kbickar kbickar deleted the kbickar:sense-1 branch Nov 13, 2018

@balloob balloob referenced this pull request Nov 29, 2018

Merged

0.83 #18776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment